Potential fixes for 2 code quality findings - #615
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates audit CSV formula protection and retention-setting error handling.
Changes:
- Detects formula-like values after leading whitespace/control characters.
- Handles retention-setting lookup failures before saving changes.
File summaries
| File | Summary |
|---|---|
src/web/api_handlers_audit.c |
Updates CSV sanitization and audit settings error handling. Two moderate issues remain regarding blank-value modification and unpropagated database read failures. |
Review details
Suppressed comments (1)
src/web/api_handlers_audit.c:401
db_audit_get_retention_days()does not propagate SQL read failures:retention_days_locked()keeps the default when prepare/step fails, while the wrapper still returns 0. Therefore this new check cannot detect the database failure it is intended to handle and the handler can continue with a fabricatedprevious_daysvalue; make the getter expose the read error (or otherwise provide a real status) before relying on this check.
if (db_audit_get_retention_days(&previous_days) != 0) {
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ensure cursor is not null before checking character. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
matteius
deleted the
ai-findings-autofix/src-web-api_handlers_audit.c
branch
September 15, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 2/4 suggestions from code quality AI findings. 2 suggestions were skipped to avoid creating conflicts.